[ci-visibility] Use correct repository URL for git metadata upload #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.35 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3253 +/- ##
=======================================
Coverage 86.02% 86.03%
=======================================
Files 194 194
Lines 7514 7517 +3
Branches 33 33
=======================================
+ Hits 6464 6467 +3
Misses 1050 1050
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uurien
reviewed
Jun 19, 2023
uurien
approved these changes
Jun 19, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Merged
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The logic to extract the repository URL to set as test span tags is the following: if it's extracted via CI provider's environment variables, it takes precedence over calling
gitbinary.We should have the same logic for uploading git metadata: rather than relying on
gitbinary as the source immediately, we should use the repository URL that was already calculated, if it's there.Motivation
Consistency when uploading git metadata.
Plugin Checklist